[PWGDQ] Add J/psi-muon correlations task#17059
Open
kaareendrup wants to merge 25 commits into
Open
Conversation
kaareendrup
requested review from
XiaozhiBai,
alibuild,
iarsene,
mcoquet642 and
mguilbau
as code owners
July 14, 2026 12:39
github-actions
Bot
changed the title
|
O2 linter results: ❌ 24 errors, |
Please consider the following formatting changes to AliceO2Group#17059
Collaborator
|
Error while checking build/O2Physics/code-check for 502cc26 at 2026-07-14 22:32: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 670d426 at 2026-07-17 14:36: Full log here. |
vkucera
reviewed
Jul 16, 2026
Comment on lines
+112
to
+113
| float* fValuesDilepton; | ||
| float* fValuesMuon; |
Collaborator
There was a problem hiding this comment.
Don't use raw pointers. Why do you even need pointers here?
Contributor
Author
There was a problem hiding this comment.
Hi Vit,
Good catch! I have just adopted what is done in more general DQ tasks (see tableReader_withAssoc.cxx) but it should be no problem to do without pointers or with smart pointers. I will push an update once I have tested locally.
vkucera
reviewed
Jul 16, 2026
Comment on lines
+130
to
+131
| fValuesDilepton = new float[VarManager::kNVars]; | ||
| fValuesMuon = new float[VarManager::kNVars]; |
vkucera
changed the title
Collaborator
|
Error while checking build/O2Physics/code-check for 0ddc0ed at 2026-07-17 17:06: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple task to produce correlations between dimuon J/Psi candidates and single muons in the way of PWGDQ-130